Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-pipelines: use 10.14 (and Swift) #6113

Merged
merged 6 commits into from
May 10, 2019
Merged

azure-pipelines: use 10.14 (and Swift) #6113

merged 6 commits into from
May 10, 2019

Conversation

amyspark
Copy link
Contributor

@amyspark amyspark commented May 9, 2019 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

(Followup to #6062)

Alternative to #6061: there is now a macOS-10.14 image at Azure pipelines:

Per #6061 (comment), switch brew's azure script and the script generated by tap-new to use 10.14 instead of 10.13.

(@amyspark here) Also switch to Swift for trashing files in Cask, as AppleScript is currently timing out in CI.

@amyspark
Copy link
Contributor Author

amyspark commented May 9, 2019

FTR, I had to rebase the branch to trigger CI.

@scpeters scpeters mentioned this pull request May 9, 2019
Closed
6 tasks
@scpeters
Copy link
Member

scpeters commented May 9, 2019

well done!

@MikeMcQuaid MikeMcQuaid merged commit ea0b36f into Homebrew:master May 10, 2019
@MikeMcQuaid
Copy link
Member

Great work again @amyspark and thanks to you too @scpeters! Could one of you submit a PR to Homebrew/homebrew-test-bot to do the same?

@amyspark amyspark mentioned this pull request May 10, 2019
Merged
@amyspark amyspark deleted the azure_mojave_only branch May 10, 2019 12:34
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amyspark @scpeters @MikeMcQuaid